Skip to content

Default XH_CONFIG_DIR to ~/.config/xh in macOS #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

ducaale
Copy link
Owner

@ducaale ducaale commented Jan 28, 2024

This is a potentially disruptive change but aligns us better with our docs and HTTPie.

Addresses #352

@ducaale ducaale linked an issue Jan 28, 2024 that may be closed by this pull request
@blyxxyz
Copy link
Collaborator

blyxxyz commented Jan 28, 2024

Maybe we can use the old location if it exists and the new one doesn't?

I'm also curious what other tools use in this case, I'll try to do a survey later.

@blyxxyz
Copy link
Collaborator

blyxxyz commented Jan 28, 2024

I checked a few programs in my (Linux) ~/.config:

I'm sold, ~/.config is the way to go for CLI tools.

HTTPie prioritizes its own legacy ~/.httpie fallback if that exists, without checking the XDG dir, so a bit simpler than my suggestion. But I think the more complicated logic is worth it.

ducaale and others added 2 commits January 28, 2024 20:43
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
Co-authored-by: Jan Verbeek <jan.verbeek@posteo.nl>
@ducaale ducaale merged commit fef79eb into master Jan 28, 2024
@ducaale ducaale deleted the macos-config-dir branch January 28, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

macos: xh config directory not in xdg dirs
2 participants