Skip to content

Conversation

zuisong
Copy link
Contributor

@zuisong zuisong commented Jan 22, 2025

@zuisong zuisong marked this pull request as ready for review January 22, 2025 14:25
@zuisong zuisong marked this pull request as draft January 23, 2025 05:31
@zuisong zuisong marked this pull request as ready for review January 23, 2025 06:06
@ducaale ducaale mentioned this pull request Feb 19, 2023
28 tasks
@zuisong zuisong marked this pull request as draft February 4, 2025 14:26
@zuisong zuisong marked this pull request as ready for review February 4, 2025 14:56
@zuisong
Copy link
Contributor Author

zuisong commented Feb 5, 2025

I've incorporated all your suggested improvements. 😄

Could you please review for any other areas needing improvement?

Should I squash into a single commit before merging the code?

Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, almost there!

@zuisong
Copy link
Contributor Author

zuisong commented Feb 6, 2025

thanks, I've incorporated all your suggested improvements.

@ducaale
Copy link
Owner

ducaale commented Feb 10, 2025

The changes look good to me. Is there anything else we want to address before this can be merged @blyxxyz?

Copy link
Collaborator

@blyxxyz blyxxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@ducaale ducaale merged commit 4873dc9 into ducaale:master Feb 12, 2025
9 checks passed
@zuisong zuisong deleted the compress-request-body branch February 13, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants