Skip to content

Remove vendored reqwest_cookie_store & store default paths for cookies without an explicit path attribute #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

otaconix
Copy link
Contributor

Copy-paste of note in commit:

Note that this commit does not alter the storage format of sessions.
Perhaps requiring a cookie path at all times would be a good idea, but
I haven't done that here, because I don't want to break existing
sessions for users.

Fixes: #399 #400

Stefan Zwanenburg added 2 commits January 19, 2025 13:23
…Set-Cookie

Note that this commit does not alter the storage format of sessions.
Perhaps requiring a cookie path at all times would be a good idea, but
I haven't done that here, because I don't want to break existing
sessions for users.

Fixes: ducaale#400
@otaconix
Copy link
Contributor Author

This PR fixes two separate issues. Let me know if you'd prefer separate PR's!

Copy link
Owner

@ducaale ducaale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ducaale ducaale merged commit df9003e into ducaale:master Jan 19, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reason for vendoring reqwest_cookie_store is now obsolete
2 participants