Skip to content

Conversation

scravy
Copy link
Member

@scravy scravy commented Mar 28, 2019

#793 introduced comments which produce warnings in gcc as they use the blackslash character at the end of a line. The backslash character continues a line which means that:

int x = 3;
// comment \
x = 4;
std::cout << x << std::endl;

would adjoin the line x = 4 to the comment before. The snippet above will print 3, clearly not what was intended. The syntax highlight here in github shows this nicely too.

@kostyantyn and I were discussing to use a unicode character instead, but unfortunately having unicode characters in the codebase screws up some lint scripts :-(

So I am going for the alternative proposed by @kostyantyn , which is to use

|
>

instead for the ascii graphic.

Signed-off-by: Julian Fleischer julian@thirdhash.com

Signed-off-by: Julian Fleischer <julian@thirdhash.com>
@scravy scravy requested a review from a team March 28, 2019 11:36
@scravy scravy self-assigned this Mar 28, 2019
@scravy scravy added the technical debt Cleaning up code which is there for historical reasons label Mar 28, 2019
Copy link
Member

@frolosofsky frolosofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 42444a8

Copy link
Member

@kostyantyn kostyantyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! utACK 42444a8

@scravy scravy merged commit 0a1d375 into dtr-org:master Mar 28, 2019
@scravy scravy deleted the fix-comments branch April 6, 2019 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
technical debt Cleaning up code which is there for historical reasons
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants