Skip to content

Conversation

scravy
Copy link
Member

@scravy scravy commented May 16, 2019

Signed-off-by: Julian Fleischer julian@thirdhash.com

Signed-off-by: Julian Fleischer <julian@thirdhash.com>
@scravy scravy added ci Continuous integration tests Automated tests wip Work in progress which is not supposed to be merged yet labels May 16, 2019
@scravy scravy requested review from nzmdn and a team May 16, 2019 13:40
@scravy scravy self-assigned this May 16, 2019
Copy link
Member

@cmihai cmihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 42621d0

Signed-off-by: Julian Fleischer <julian@thirdhash.com>
@frolosofsky
Copy link
Member

lint-clang-format is used for src/, and lint-newline-at-eof is for both src/ and test/. Why have they been moved to test/ dir?

Copy link
Member

@cornelius cornelius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ConceptACK 3fcad73

@scravy
Copy link
Member Author

scravy commented May 16, 2019

Since bitcoin 0.17 all linters reside in test/lint.

Signed-off-by: Julian Fleischer <julian@thirdhash.com>
Copy link
Member

@frolosofsky frolosofsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 2147124

Signed-off-by: Julian Fleischer <julian@thirdhash.com>
Copy link
Member

@nzmdn nzmdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 025ffd0

@scravy scravy removed the wip Work in progress which is not supposed to be merged yet label May 16, 2019
@scravy
Copy link
Member Author

scravy commented May 16, 2019

This pull request also executes all linters always now (instead of exiting on first erroring script).

Backporting to bitcoin in bitcoin/bitcoin#16036

@scravy scravy merged commit b992ec1 into dtr-org:master May 16, 2019
frolosofsky added a commit to frolosofsky/unit-e that referenced this pull request May 17, 2019
The dtr-org#1101 broke pre-commit git hook by moving linter from `contrib/devtools` to`test/lint`
directory. This commit fixes that.

Signed-off-by: Stanislav Frolov <stanislav@thirdhash.com>
@frolosofsky frolosofsky mentioned this pull request May 17, 2019
frolosofsky added a commit that referenced this pull request May 17, 2019
The #1101 broke pre-commit git hook by moving linter from `contrib/devtools` to`test/lint`
directory. This commit fixes that.

Signed-off-by: Stanislav Frolov <stanislav@thirdhash.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration tests Automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants