Skip to content

Conversation

oxalica
Copy link
Contributor

@oxalica oxalica commented Sep 22, 2024

Because

  1. They are indeed automatically derived.
  2. It does not break MSRV 1.56.
  3. Avoid testing Display and Error methods (and each branches inside them) for test coverage. coverage: Don't instrument #[automatically_derived] functions rust-lang/rust#120185

Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dtolnay dtolnay merged commit 023f036 into dtolnay:master Sep 22, 2024
10 checks passed
@oxalica oxalica deleted the feat/mark-auto-derived branch September 22, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants