Revert "Work around doc build failure due to docs.rs flags change" #511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 1385671.
|
Successful documentation build: https://docs.rs/proc-macro2/1.0.96/proc_macro2/struct.Span.html |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs.rs behavior that led to #309 and required #310 has been fixed in Cargo and docs.rs by rust-lang/cargo#10395 + rust-lang/docs.rs#1800. Since the fix, all the flags from
package.metadata.docs.rs.rustc-argsare now correctly applied to build script compilation as well, so we no longer need the additional logic to get--cfg=procmacro2_semver_exemptturned on during docs.rs builds.proc-macro2/Cargo.toml
Lines 15 to 16 in 6f40165