Fix lifetime on as_turbofish
#1861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to write something like this:
```rust
struct W(syn::Generics);
impl W {
pub fn as_turbofish(&self) -> syn::Turbofish<'_> {
self.0.split_for_impl().1.as_turbofish()
}
}
```
Unfortunately, that doesn't compile today and as far as I can tell it's completely unimplementable -
the lifetime of the `syn::Turbofish` ends up tied to the temporary returned by `split_for_impl`.
That seems silly and unintentional, fix it.
|
Published in 2.0.101. |
facebook-github-bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebook/dotslash
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebookincubator/reindeer
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebook/buck2-shims-meta
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
facebook-github-bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Apr 27, 2025
Summary: Pick up dtolnay/syn#1861 Reviewed By: dtolnay Differential Revision: D73726005 fbshipit-source-id: aca81e034ceb0feb522d23a334aad4761c04a6e4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to write something like this:
Unfortunately, that doesn't compile today and as far as I can tell it's completely unimplementable -
the lifetime of the
syn::Turbofishends up tied to the temporary returned bysplit_for_impl.That seems silly and unintentional, fix it.