Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.1.56
Choose a base ref
...
head repository: dtolnay/async-trait
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.1.57
Choose a head ref
  • 14 commits
  • 8 files changed
  • 1 contributor

Commits on Jun 6, 2022

  1. Configuration menu
    Copy the full SHA
    e8eafee View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2022

  1. Configuration menu
    Copy the full SHA
    4272a03 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2022

  1. Configuration menu
    Copy the full SHA
    3947859 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2022

  1. Disable test of tracing attrs on miri due to once_cell

        $ MIRIFLAGS=-Zmiri-strict-provenance cargo miri test
    
        test issue45::tracing ... error: unsupported operation: integer-to-pointer casts and `ptr::from_exposed_addr` are not supported with `-Zmiri-strict-provenance`
           --> github.com-1ecc6299db9ec823/once_cell-1.12.0/src/imp_std.rs:175:30
            |
        175 |             let mut waiter = (queue & !STATE_MASK) as *const Waiter;
            |                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ integer-to-pointer casts and `ptr::from_exposed_addr` are not supported with `-Zmiri-strict-provenance`
            |
            = help: use Strict Provenance APIs (https://doc.rust-lang.org/nightly/std/ptr/index.html#strict-provenance, https://crates.io/crates/sptr) instead
    
            = note: inside `<once_cell::imp::Guard as std::ops::Drop>::drop` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/imp_std.rs:175:30
            = note: inside `std::ptr::drop_in_place::<once_cell::imp::Guard> - shim(Some(once_cell::imp::Guard))` at nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ptr/mod.rs:487:1
            = note: inside `once_cell::imp::initialize_or_wait` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/imp_std.rs:217:13
            = note: inside `once_cell::imp::OnceCell::<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::initialize::<[closure@once_cell::sync::OnceCell<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::get_or_init<[closure@once_cell::sync::Lazy<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::force::{closure#0}]>::{closure#0}], once_cell::sync::OnceCell<T>::get_or_init::Void>` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/imp_std.rs:81:9
            = note: inside `once_cell::sync::OnceCell::<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::get_or_try_init::<[closure@once_cell::sync::OnceCell<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::get_or_init<[closure@once_cell::sync::Lazy<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::force::{closure#0}]>::{closure#0}], once_cell::sync::OnceCell<T>::get_or_init::Void>` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/lib.rs:1063:13
            = note: inside `once_cell::sync::OnceCell::<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::get_or_init::<[closure@once_cell::sync::Lazy<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::force::{closure#0}]>` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/lib.rs:1023:19
            = note: inside `once_cell::sync::Lazy::<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>>::force` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/lib.rs:1211:13
            = note: inside `<once_cell::sync::Lazy<std::sync::RwLock<std::vec::Vec<tracing_core::dispatcher::Registrar>>> as std::ops::Deref>::deref` at github.com-1ecc6299db9ec823/once_cell-1.12.0/src/lib.rs:1221:13
            = note: inside `tracing::callsite::dispatchers::Dispatchers::register_dispatch` at github.com-1ecc6299db9ec823/tracing-core-0.1.28/src/callsite.rs:545:35
            = note: inside `tracing::callsite::register_dispatch` at github.com-1ecc6299db9ec823/tracing-core-0.1.28/src/callsite.rs:480:23
            = note: inside `tracing::Dispatch::new::<issue45::TestSubscriber>` at github.com-1ecc6299db9ec823/tracing-core-0.1.28/src/dispatcher.rs:413:9
            = note: inside `tracing::subscriber::with_default::<(), issue45::TestSubscriber, [closure@tests/test.rs:627:54: 627:87]>` at github.com-1ecc6299db9ec823/tracing-0.1.35/src/subscriber.rs:24:38
        note: inside `issue45::tracing` at tests/test.rs:627:9
           --> tests/test.rs:627:9
            |
        627 |         subscriber::with_default(subscriber.clone(), || executor::block_on_simple(fut));
            |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        note: inside closure at tests/test.rs:621:5
           --> tests/test.rs:621:5
            |
        620 |       #[test]
            |       ------- in this procedural macro expansion
        621 | /     fn tracing() {
        622 | |         // Create the future outside of the subscriber, as no call to tracing
        623 | |         // should be made until the future is polled.
        624 | |         let mut struct_impl = Impl(0);
        ...   |
        636 | |         assert_eq!(*subscriber.inner.value.lock().unwrap(), Some(("val", 5, 2)));
        637 | |     }
            | |_____^
            = note: this error originates in the attribute macro `test` (in Nightly builds, run with -Z macro-backtrace for more info)
    
        note: some details are omitted, run with `MIRIFLAGS=-Zmiri-backtrace=full` for a verbose backtrace
    dtolnay committed Jul 1, 2022
    Configuration menu
    Copy the full SHA
    fc593f4 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #208 from dtolnay/oncecell

    Disable test of tracing attrs on miri due to once_cell
    dtolnay authored Jul 1, 2022
    Configuration menu
    Copy the full SHA
    d0a7da0 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2022

  1. Configuration menu
    Copy the full SHA
    408e77f View commit details
    Browse the repository at this point in the history
  2. Ignore explicit_auto_deref clippy lint

        error: deref which would be done by auto-deref
          --> src/expand.rs:85:43
           |
        85 |             lifetimes.visit_type_mut(&mut *input.self_ty);
           |                                           ^^^^^^^^^^^^^^ help: try this: `input.self_ty`
           |
           = note: `-D clippy::explicit-auto-deref` implied by `-D clippy::all`
           = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref
    dtolnay committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    c93e97c View commit details
    Browse the repository at this point in the history
  3. Temporarily disable clippy on tests due to ICE

        error: internal compiler error: compiler/rustc_typeck/src/collect.rs:1896:13: to get the signature of a closure, use `substs.as_closure().sig()` not `fn_sig()`
    
        thread 'rustc' panicked at 'Box<dyn Any>', /rustc/46b8c23f3eb5e4d0e0aa27eb3f20d5b8fc3ed51f/compiler/rustc_errors/src/lib.rs:1391:9
        stack backtrace:
           0: std::panicking::begin_panic::<rustc_errors::ExplicitBug>
           1: std::panic::panic_any::<rustc_errors::ExplicitBug>
           2: <rustc_errors::HandlerInner>::bug::<&alloc::string::String>
           3: <rustc_errors::Handler>::bug::<&alloc::string::String>
           4: rustc_middle::ty::context::tls::with_opt::<rustc_middle::util::bug::opt_span_bug_fmt<rustc_span::span_encoding::Span>::{closure#0}, ()>
           5: rustc_middle::util::bug::opt_span_bug_fmt::<rustc_span::span_encoding::Span>
           6: rustc_middle::util::bug::bug_fmt
           7: rustc_typeck::collect::fn_sig
           8: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle::ty::context::TyCtxt, rustc_span::def_id::DefId, rustc_middle::ty::sty::Binder<rustc_middle::ty::sty::FnSig>>
           9: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::plumbing::QueryCtxt, rustc_query_system::query::caches::DefaultCache<rustc_span::def_id::DefId, rustc_middle::ty::sty::Binder<rustc_middle::ty::sty::FnSig>>>
          10: <rustc_query_impl::Queries as rustc_middle::ty::query::QueryEngine>::fn_sig
          11: <&mut clippy_lints::dereference::walk_parents::{closure#0} as core::ops::function::FnMut<(rustc_hir::hir::Node, rustc_hir::hir_id::HirId)>>::call_mut
          12: clippy_utils::walk_to_expr_usage::<clippy_lints::dereference::Position, &mut clippy_lints::dereference::walk_parents::{closure#0}>
          13: <clippy_lints::dereference::Dereferencing as rustc_lint::passes::LateLintPass>::check_expr
          14: <rustc_lint::late::LateLintPassObjects as rustc_lint::passes::LateLintPass>::check_expr
          15: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          16: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          17: rustc_hir::intravisit::walk_block::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          18: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_block
          19: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          20: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          21: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_block
          22: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          23: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_nested_body
          24: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_fn
          25: rustc_hir::intravisit::walk_expr::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          26: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          27: rustc_hir::intravisit::walk_expr::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          28: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_expr
          29: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_nested_body
          30: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_fn
          31: rustc_hir::intravisit::walk_item::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          32: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_nested_item
          33: rustc_hir::intravisit::walk_mod::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          34: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_mod
          35: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_nested_item
          36: rustc_hir::intravisit::walk_mod::<rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects>>
          37: <rustc_lint::late::LateContextAndPass<rustc_lint::late::LateLintPassObjects> as rustc_hir::intravisit::Visitor>::visit_mod
          38: rustc_lint::late::late_lint_pass_crate::<rustc_lint::late::LateLintPassObjects>
          39: rustc_lint::late::late_lint_crate::<rustc_lint::BuiltinCombinedLateLintPass>
          40: rustc_data_structures::sync::join::<rustc_lint::late::check_crate<rustc_lint::BuiltinCombinedLateLintPass, rustc_interface::passes::analysis::{closure#5}::{closure#1}::{closure#2}::{closure#0}::{closure#0}>::{closure#0}, rustc_lint::late::check_crate<rustc_lint::BuiltinCombinedLateLintPass, rustc_interface::passes::analysis::{closure#5}::{closure#1}::{closure#2}::{closure#0}::{closure#0}>::{closure#1}, (), ()>
          41: <rustc_session::session::Session>::time::<(), rustc_interface::passes::analysis::{closure#5}::{closure#1}::{closure#2}::{closure#0}>
          42: <core::panic::unwind_safe::AssertUnwindSafe<rustc_interface::passes::analysis::{closure#5}::{closure#1}> as core::ops::function::FnOnce<()>>::call_once
          43: <rustc_session::session::Session>::time::<(), rustc_interface::passes::analysis::{closure#5}>
          44: rustc_interface::passes::analysis
          45: <rustc_query_system::dep_graph::graph::DepGraph<rustc_middle::dep_graph::dep_node::DepKind>>::with_task::<rustc_middle::ty::context::TyCtxt, (), core::result::Result<(), rustc_errors::ErrorGuaranteed>>
          46: rustc_query_system::query::plumbing::try_execute_query::<rustc_query_impl::plumbing::QueryCtxt, rustc_query_system::query::caches::DefaultCache<(), core::result::Result<(), rustc_errors::ErrorGuaranteed>>>
          47: rustc_query_system::query::plumbing::get_query::<rustc_query_impl::queries::analysis, rustc_query_impl::plumbing::QueryCtxt>
          48: <rustc_interface::passes::QueryContext>::enter::<rustc_driver::run_compiler::{closure#1}::{closure#2}::{closure#3}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>
          49: <rustc_interface::interface::Compiler>::enter::<rustc_driver::run_compiler::{closure#1}::{closure#2}, core::result::Result<core::option::Option<rustc_interface::queries::Linker>, rustc_errors::ErrorGuaranteed>>
          50: rustc_span::with_source_map::<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_interface::interface::create_compiler_and_run<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#1}>
          51: <scoped_tls::ScopedKey<rustc_span::SessionGlobals>>::set::<rustc_interface::interface::run_compiler<core::result::Result<(), rustc_errors::ErrorGuaranteed>, rustc_driver::run_compiler::{closure#1}>::{closure#0}, core::result::Result<(), rustc_errors::ErrorGuaranteed>>
        note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace.
    
        note: the compiler unexpectedly panicked. this is a bug.
    
        note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new
    
        note: Clippy version: clippy 0.1.64 (46b8c23 2022-07-01)
    
        query stack during panic:
        #0 [fn_sig] computing function signature of `issue149::ok::{closure#0}`
        #1 [analysis] running analysis passes on this crate
        end of query stack
        error: could not compile `async-trait`
    dtolnay committed Jul 2, 2022
    Configuration menu
    Copy the full SHA
    f1d6746 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #209 from dtolnay/ice

    Temporarily disable clippy on tests due to ICE
    dtolnay authored Jul 2, 2022
    Configuration menu
    Copy the full SHA
    2cc3532 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Avoid cargo 1.43–1.45 in GitHub Actions

    These versions are incompatible with some recent GitHub change.
    
        error: failed to get `proc-macro2` as a dependency of package `async-trait v0.1.56 (/home/runner/work/async-trait/async-trait)`
    
        Caused by:
          failed to load source for dependency `proc-macro2`
    
        Caused by:
          Unable to update registry `https://github.com/rust-lang/crates.io-index`
    
        Caused by:
          failed to fetch `https://github.com/rust-lang/crates.io-index`
    
        Caused by:
          error reading from the zlib stream; class=Zlib (5)
    dtolnay committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    a386446 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Configuration menu
    Copy the full SHA
    f997ace View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    81704b3 View commit details
    Browse the repository at this point in the history
  3. Revert "Temporarily disable clippy on tests due to ICE"

    This reverts commit f1d6746.
    dtolnay committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    4124033 View commit details
    Browse the repository at this point in the history
  4. Release 0.1.57

    dtolnay committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    7aa083c View commit details
    Browse the repository at this point in the history
Loading