Include directive must only use files in the same directory #285
Conversation
|
Warning Rate limit exceeded@dthaler has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 10 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
WalkthroughThe changes clarify the usage of the Changes
Sequence Diagram(s)sequenceDiagram
participant Caller as Caller
participant Process as process_line
participant Console as std::cerr
Caller->>Process: Call process_line(line with include directive)
Process->>Process: Check if filename contains '/' or '\\'
alt Filename contains path separator
Process->>Console: Print error message
Process-->>Caller: Return error code (non-zero)
else Normal filename
Process-->>Caller: Process include normally and return success code
end
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Fixes #283 Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
test/basic_tests.cpp (1)
1524-1544: LGTM! Comprehensive test coverage for include directive restrictions.The test cases effectively validate:
- Rejection of includes from parent directories
- Rejection of non-existent files
Consider adding these additional test cases for completeness:
- Include from a subdirectory
- Include from the same directory (positive test case)
Here's a suggested implementation for the additional test cases:
+TEST_CASE("include from subdirectory", "[include]") +{ + test_rst2rfcxml( + R"( +.. include:: subdir/sample.rst +)", + "", + 1); +} + +TEST_CASE("include from same directory", "[include]") +{ + test_rst2rfcxml( + R"( +.. include:: sample.rst +)", + "<t>\n Sample content\n</t>\n", + 0); +}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README.md(1 hunks)lib/rst2rfcxml.cpp(1 hunks)test/basic_tests.cpp(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- README.md
- lib/rst2rfcxml.cpp
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build_windows (Release)
🔇 Additional comments (1)
test/basic_tests.cpp (1)
32-38: LGTM! Well-structured error handling enhancement.The function signature update and error code validation are well-implemented. The default value of 0 maintains backward compatibility with existing test cases.
Signed-off-by: Dave Thaler <dthaler1968@gmail.com>
Fixes #283
Summary by CodeRabbit
Documentation
Bug Fixes
Tests