-
Notifications
You must be signed in to change notification settings - Fork 38
Feature #3054 develop scan_for_CVEs #3055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature #3054 develop scan_for_CVEs #3055
Conversation
… scheduled weekly runs for one or more versions, and update the logic for pushing X.Y-latest tags to Docker Hub.
…the GHA release workflows.
…low for version 6.1.0.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have reviewed the code changes, the output of the linked GHA run, and the Release Guide updates. Thank you for noting that all errors are based on the METplus-Analysis tools problem with kaleido. I approve this request. Thanks for all of your work on this task @JohnHalleyGotway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for updating metplus_components_v6.1_py3.12.sh!
…ot actually impact the GHA testing environment.
…n to 1.0.0 in the documentation and internal scripts. Hoping that will enable the 4 failing METplus use cases to succeed.
Pull Request Testing
This PR proposes enhancements to the
develop
branch to add CVE scanning to the existingrelease-docker-images.yml
workflow. The 12 modified files include changes for:[1]
bash_functions.sh
to add thecve_scan_image
function and enhance the existingtime_command
function to redirect log output to a file which is already supported in MET and METviewer.[1]
docker_build_metplus_images.sh
removes theis_official
variable and move the handling ofX.Y-latest
images from here todocker_push_metplus_images.sh
.[1]
docker_push_metplus_images.sh
adds logic for handlingX.Y-latest
images.[1]
docker_scan_metplus_images.sh
is new and calls thecve_scan_image
to run grype on the 2 METplus images and write the result to a log file.[1]
release-docker-images.yml
workflow can now be run for new releases, through workflow_dispatch, and on a cron schedule (3 hours after the MET cron is run weekly). Thedefine-matrix
job is new to handle building images for multiple versions. And Syft/Grype are installed to support the new scanning step. Note that this is updated to reference the newDOCKER_TOKEN
repository secret rather than building/pushing as @georgemccabe.[7] The
Release_Guide
docs are updated by adding new instructions for updating the Docker image workflow inupdate_docker_image_workflow.rst
. And then those instructions are referenced in the official and bugfix instructions for MET, METplus, and METviewer.Describe testing already performed for these changes:
Manually ran the updated
release-docker-images.yml
workflow in this GHA run, and confirmed that it ran as expected and produced the expected scanning results. I downloaded/inspected the error logs and found that all errors are based on the METplus-Analysis tools problem with kaleido:Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review code changes, the output of the run linked above, and the Release Guide updates.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [No]
None needed.
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Note however that 4 of the METplus use cases failed in this GHA Pull Request testing workflow run.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Thurs July 17, 2025].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases