Skip to content

Conversation

georgemccabe
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Added unit test to demonstrate bug, then fix it.
Also used @CPKalb 's use case to debug issue and come up with a fix.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Confirm changes cause your use case to work properly

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 5/30/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…ast valid time to check for an accumulation -- The search time minus the output accumulation is used as the reference time to compute the number of seconds of the input accumulation. The input accumulation is subtracted from this time to determine the number of seconds, which depending on the time can cross over a leap year when the actual accumulation calculations do not. This fix adds the input accumulation to the 'first' time to ensure that it is correctly calculated
@georgemccabe georgemccabe added this to the METplus-6.2.0 milestone May 28, 2025
@georgemccabe georgemccabe requested a review from CPKalb May 28, 2025 22:46
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.2 Development May 28, 2025
@georgemccabe georgemccabe linked an issue May 28, 2025 that may be closed by this pull request
24 tasks
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.2 Development May 28, 2025
Copy link
Contributor

@CPKalb CPKalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it fixed the bug of PCP combine derive lookback failing for 3 year accumulations.

@georgemccabe georgemccabe merged commit 7fe87d5 into develop May 29, 2025
82 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.2 Development May 29, 2025
@georgemccabe georgemccabe deleted the bugfix_2980_develop_pcp_yearly branch May 29, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: PCP Combine not working for 3 year averaging
2 participants