Skip to content

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

Installed on various machines where modulefiles were updated and reviewed existing builds updates in RTD:
https://metplus.readthedocs.io/en/feature_2953_installation_files/Users_Guide/release-notes.html

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review files changed for obvious errors, ensure tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [ASAP].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • For any new datasets, an entry to the METplus Verification Datasets Guide.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METplus-6.1.0 milestone Apr 11, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development Apr 11, 2025
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development Apr 11, 2025
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Julie, please modify the contents of the testing.yml workflow to ignore changes in the internal/scripts/installation directory since they have no impact on the automated testing and running all those extra checks is unnecessary.

@jprestop
Copy link
Collaborator Author

I have updated testing.yml and requested a re-review.

Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

Thanks for updating testing.yml to ignore future changes in the internal/scripts/installation directory. Ironically, I suspect it was that change to testing.yml that triggered it to run a second time, since workflow changes are not ignored... which is very meta.

I do note that failures were flagged in the testing.yml workflow, which are noteworthy, but clearly unrelated to these changes. I skimmed the modified files and at RTD and don't see any obvious issues with the content.

@jprestop jprestop merged commit ca2d95d into develop Apr 11, 2025
76 of 78 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Apr 11, 2025
@jprestop jprestop linked an issue Apr 15, 2025 that may be closed by this pull request
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Update installation modulefiles for Python 3.12 and the Existing Builds documentation Create new script to build the conda env for Python 3.12
2 participants