-
Notifications
You must be signed in to change notification settings - Fork 38
Feature 2953 installation files #2958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Julie, please modify the contents of the testing.yml
workflow to ignore changes in the internal/scripts/installation
directory since they have no impact on the automated testing and running all those extra checks is unnecessary.
I have updated testing.yml and requested a re-review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve of these changes.
Thanks for updating testing.yml
to ignore future changes in the internal/scripts/installation
directory. Ironically, I suspect it was that change to testing.yml
that triggered it to run a second time, since workflow changes are not ignored... which is very meta.
I do note that failures were flagged in the testing.yml
workflow, which are noteworthy, but clearly unrelated to these changes. I skimmed the modified files and at RTD and don't see any obvious issues with the content.
Pull Request Testing
Installed on various machines where modulefiles were updated and reviewed existing builds updates in RTD:
https://metplus.readthedocs.io/en/feature_2953_installation_files/Users_Guide/release-notes.html
Review files changed for obvious errors, ensure tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [ASAP].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplus-Wrappers-X.Y.Z Development project for official releases