Skip to content

Conversation

CPKalb
Copy link
Contributor

@CPKalb CPKalb commented Apr 25, 2024

Pull Request Testing

  • Describe testing already performed for these changes:

    Checked to see that they passed and that documentation looked tood

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Check that there are no more references to MTD_FCST/OBS_CONV_RADIUS and MTD_FCST/OBS_CONV_THRESH. Also the MTD conv radius and threshold should all say they need a single number (rather than a list)
    https://metplus.readthedocs.io/en/bugfix_mtd_documentation/

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
    yes

  • Do these changes include sufficient testing updates? [Yes or No]
    No sure??? It was a simple documentation fix

  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

    No

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:
    No

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@CPKalb CPKalb requested a review from georgemccabe April 25, 2024 21:26
@CPKalb CPKalb added the component: documentation Documentation issue label Apr 25, 2024
Copy link
Collaborator

@georgemccabe georgemccabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggested a minor change to the wording in the glossary to make it clear that the value should be a comparison operator and a number, not just a number. Other than that, everything looks good!

CPKalb and others added 2 commits April 26, 2024 12:10
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
@CPKalb
Copy link
Contributor Author

CPKalb commented Apr 26, 2024

Changes are great, thanks! I commited them to the branch.

@CPKalb CPKalb requested a review from georgemccabe April 26, 2024 19:20
@georgemccabe georgemccabe merged commit 828068c into develop Apr 26, 2024
@georgemccabe georgemccabe deleted the bugfix_mtd_documentation branch April 26, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Documentation issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants