Feature dtcenter/MET#2796 main_v5.1 GHA Node20 deprecation warnings #2474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed node warnings in GHA runs - main_v5.1
… of sphinx-gallery: see https://blog.readthedocs.com/defaulting-latest-build-tools/ for more info on why this was necessary
…s that were fixed in develop but not in main_v5.1
JohnHalleyGotway
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I approve of these changes.
These are the same set of changes made to the develop branch by PR #2473. I do note the doc-only update to the contents of requirements.txt. While the testing workflow has not yet finished for this PR, the documentation workflow has and it completed without error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2473
Also added a fix to docs/requirements.txt that was applied to develop but not main that prevents failure in ReadTheDocs builds.