Skip to content

Conversation

John-Sharples
Copy link
Contributor

In this PR:

  • some tests to improve coverage of command_builder
  • new test files for run_util, including dummy config files.
  • tests for pre_run_setup in run_util.py. Tests for other function will follow in a futrue PR

Pull Request Testing

  • Describe testing already performed for these changes:

    Tests passing locally

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Nothing specific - more options/items could be added to the test config files if there's specific functionality to test

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation?
    yes

  • Do these changes include sufficient testing updates? [Yes or No]

  • Will this PR result in changes to the test suite? [Yes or No]

    Yes - extra tests will run for run_util and command_builder

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: @georgemccabe
    Select:
    Select:
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe merged commit ac15ac1 into dtcenter:develop Aug 15, 2023
@John-Sharples John-Sharples deleted the feature_2253_run_util_tests branch September 18, 2023 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants