Skip to content

Bugfix #1853 develop - PointStat don't require mask variables to be set #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 25, 2023
Merged

Bugfix #1853 develop - PointStat don't require mask variables to be set #2262

merged 2 commits into from
Jul 25, 2023

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jul 24, 2023 •
edited
Loading

Pull Request Testing

  • Describe testing already performed for these changes:

Added new unit tests to ensure correct behavior. Ran PointStat.conf basic use case example with a variety of settings to ensure the correct behavior is possible

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Test existing use case to ensure it can now be configured as expected

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    New/updated unit tests but they should all pass

  • Please complete this pull request review by 7/27/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe
removed unused test files
9425dea
@georgemccabe
per #1853, handle mask dictionary for PointStat so that a user can le…
0f0e61e 
…ave all mask variables unset in the METplus config to use the default values
@georgemccabe georgemccabe added this to the METplus-5.1.0 milestone Jul 24, 2023
@georgemccabe georgemccabe linked an issue Jul 24, 2023 that may be closed by this pull request
Bugfix: PointStat - Support running with no MASK provided #1853
Closed
23 tasks
DanielAdriaansen
DanielAdriaansen requested changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the __init__.py file needed?

@georgemccabe
Copy link
Collaborator Author

@DanielAdriaansen, no. That is why it was removed. I don't know why it was added there in the first place.

Is the __init__.py file needed?

@DanielAdriaansen
Copy link
Contributor

@DanielAdriaansen, no. That is why it was removed. I don't know why it was added there in the first place.

Is the __init__.py file needed?

Sorry I misinterpreted the "Files Changed" view. I did not notice the file was 'deleted' but rather just noted it said "empty file" and so thought we were adding an empty file but in reality it has been deleted. Sorry about that.

DanielAdriaansen
DanielAdriaansen approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@DanielAdriaansen DanielAdriaansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested on Seneca using the met_tool_wrapper/PointStat.conf file. In that file, I commented out these lines:

#POINT_STAT_MASK_GRID = DTC165, DTC166
#POINT_STAT_MASK_POLY = MET_BASE/poly/LMV.poly
#POINT_STAT_MASK_SID =
#POINT_STAT_MASK_LLPNT =

When using run_metplus.py from the develop branch, this causes a failure reported by point_stat. When I use run_metplus.py from this branch, point_stat succeeds.

Thanks @georgemccabe!

@georgemccabe georgemccabe merged commit 3a43be0 into develop Jul 25, 2023
@georgemccabe georgemccabe deleted the bugfix_1853_develop_no_mask branch July 25, 2023 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielAdriaansen DanielAdriaansen DanielAdriaansen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
METplus-Wrappers-5.1.0 Development
Status: Done
Milestone
METplus-5.1.0
Development

Successfully merging this pull request may close these issues.

Bugfix: PointStat - Support running with no MASK provided
2 participants
@georgemccabe @DanielAdriaansen