Skip to content

Conversation

georgemccabe
Copy link
Collaborator

Note: These changes will change the default METplus log lines to include metplus.XXXXXXXX instead of metplus where XXXXXXXX is the unique ID of the run. This information can be removed from the log format if desired by modifying the METplus config variables.

Pull Request Testing

  • Describe testing already performed for these changes:

Forced unit test to fail and confirmed that the log file for the failed test only contains log content from its run instead of logs from every test.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
  • Ensure all tests pass (except PBL use case which will be remedied in another PR)
  • Note decrease in time to run pytests in automated tests
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

The pytests should run substantially faster than before

  • Please complete this pull request review by 7/14/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…oncurrent runs do not use the same logger instance
@georgemccabe georgemccabe added this to the METplus-5.1.0 milestone Jul 13, 2023
@georgemccabe georgemccabe changed the title Bugfix #2245 use unique run ID to name logger instance Bugfix #2245 use unique run ID to name logger instance Jul 13, 2023
@georgemccabe georgemccabe linked an issue Jul 13, 2023 that may be closed by this pull request
23 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I reviewed the small change to the name of the logging instance to include the runid. I note that all unit tests did pass - even the PBL one we suspected might not. I also note that the pytests ran in about 3:30.

@georgemccabe georgemccabe merged commit 34ff190 into develop Jul 13, 2023
@georgemccabe georgemccabe deleted the bugfix_2245_develop_unique_logs branch July 13, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Ensure log instances for concurrent runs are unique
2 participants