Skip to content

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented May 31, 2023

Pull Request Testing

  • Describe testing already performed for these changes:

Added failing unit tests to demonstrate bug, then fixed them

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    New/updated unit tests but they should all pass

  • Please complete this pull request review by 6/6/2023.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development issue with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the METplus-5.0.2 Bugfix milestone May 31, 2023
@georgemccabe georgemccabe requested a review from bikegeek May 31, 2023 22:12
… release 3.18.0 that does not include docker-compose in the apk repository
@georgemccabe georgemccabe merged commit f4d27b5 into main_v5.0 Jun 1, 2023
@georgemccabe georgemccabe linked an issue Jun 1, 2023 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe deleted the bugfix_2189_main_v5.0_complex_thresh branch June 1, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Bugfix: Allow spaces for complex categorical thresholds
2 participants