Skip to content

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Oct 21, 2022

Pull Request Testing

  • Describe testing already performed for these changes:

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

Added a test to the corresponding develop branch fix to ensure that the change works as expected

  • Will this PR result in changes to the test suite? [No]

  • Please complete this pull request review by 10/26/2022.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select Development with the original issue number.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…emplate tag from being used in 2nd file for PCPCombine subtract method
@georgemccabe georgemccabe added this to the METplus-4.1.5 Bugfix milestone Oct 21, 2022
@georgemccabe georgemccabe linked an issue Oct 21, 2022 that may be closed by this pull request
23 tasks
@georgemccabe georgemccabe changed the title Bbugfix #1884 PCPCombine {custom} in subtract method Bbugfix #1884 main_v4.1 PCPCombine {custom} in subtract method Oct 21, 2022
@georgemccabe georgemccabe changed the title Bbugfix #1884 main_v4.1 PCPCombine {custom} in subtract method Bugfix #1884 main_v4.1 PCPCombine {custom} in subtract method Oct 24, 2022
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this change.

I see that it's the main_v4.1 companion to PR #1887. Its the same fix, minus the addition of the new test.

@georgemccabe georgemccabe merged commit 9daac01 into main_v4.1 Oct 24, 2022
@georgemccabe georgemccabe deleted the bugfix_1884_main_v4.1_pcp_combine_custom_subtract branch October 24, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Bugfix: PCPCombine - custom loop list does not work for subtract method
2 participants