There are two main things that could be improved in this wrapper.

1. Set cyclone to current cyclone if processing individually

Currently the wrapper passes in the full list of cyclones to process from the METplus config for every run. This works fine if the input files are sorted by cyclone since the input file contains only that cyclone. If the input file contains many cyclones and a list of cyclones are specified in the METplus config, the wrapper will loop over these values and process once for each. The same input file is read and the output files contain the cyclone in the filename (if included in the template), but each file will contain all cyclones listed in the config file.

If we are looping over a list of cyclones and processing once for each, the environment variable CYCLONE should only contain the current cyclone being processed, not the full list of cyclones.

2. * added to output filename if processing all cyclones

If no cyclones are specified in the METplus config, all of the available cyclones will be processed. However, if the cyclone template is not specified in the input file template, the output file will contain * as the cyclone value. If * is set for the cyclone value in this case, it should be replaced with "all" or something similar to avoid created a problematic filename.

Describe the Enhancement

See above

Time Estimate

1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues.

• Add a checkbox for each sub-issue here.

Relevant Deadlines

None

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Review projects and select relevant Repository and Organization ones or add "alert:NEED PROJECT ASSIGNMENT" label
• Select milestone to next major version milestone or "Future Versions"

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s), Project(s), Milestone, and Linked issues
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.