-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Describe Expected Changes
dtcenter/METbaseimage#14 updates the GHA Docker environment to use Debian version 12 (bookworm). This changes the compiler version from gcc (Debian 8.3.0-6) 8.3.0
to gcc (Debian 12.2.0-14) 12.2.0
. It also the compile_MET_all.sh
script that was updated by dtcenter/MET#2672 to compile the new dependency on the Proj library.
As described in this PR comment changes are introduced to the MET unit test output as a result of upgrading the gfortran compiler version.
It is likely that similar differences will exist in the output of the METplus use cases.
This issue is to check for those differences, verify that all are reasonable, and update the truth dataset accordingly.
Define the Metadata
Title
- Add a link to the pull request that warranted this issue to the issue title using format dtcenter/{REPO}#{PR_NUMBER}.
Example: Update Truth: For dtcenter/MET#2655
Assignee
Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Update Truth Checklist
- Review the GitHub Actions workflow that was triggered by the PR merge
- If no differences were found, note this in a comment.
- If all of the differences are expected, note this in a comment.
Include any details of how the review was performed. - If unexpected differences are found, the following instructions can
help uncover potential explanations. If none of these apply and the
source of the differences cannot be determined, contact the
METplus wrappers lead engineer (@georgemccabe) for assistance.- Search for other open issues that have the label
type: update truth
applied by clicking on the label on this issue. Coordinate with the
author of these issues to ensure all diffs are properly reviewed. - Check if any additional GitHub Actions testing workflows have been
triggered since the workflow that corresponds to this issue was run.
Review the latest run to ensure that there are no diffs that are
unrelated to this issue. - If the incorrect differences are caused by the changes from the
issue that warranted this issue, consider reverting the PR and
re-opening the issue.
- Search for other open issues that have the label
- Iterate until one of the above conditions apply.
- Approve the update of the truth data
- Contact the METplus wrappers lead engineer (@georgemccabe) or
backup lead (@jprestop) to let them know that the truth data can
be updated.
- Contact the METplus wrappers lead engineer (@georgemccabe) or
- Update the truth data.
This should be handled by a METplus wrappers engineer.
See the (instructions to update the truth data)[https://metplus.readthedocs.io/en/develop/Contributors_Guide/continuous_integration.html#update-truth-data-update-truth-data-yml]
for more info. - Close this issue.