Skip to content

Enhancement: Improve time formatting logic to include certain times and use day of week to subset #2283

@georgemccabe

Description

@georgemccabe

The wrappers currently support SKIP_TIMES to exclude certain times from being processed. It would be useful to support a similar setting to only process times that DO match a certain time format, e.g. run only on the 1st and 15th of a month instead of excluding 2-14 and 16-31.

It would also be useful to include/exclude other Python time directives (see https://strftime.org/), e.g. only run on Monday, Wednesday, and Friday.

Describe the Enhancement

  • Enhance the wrapper logic to allow users to provide a list of time directives that must match to process
  • Add support to include/exclude other time directives like day of week (including but not exclusively %a, %A, and %w)

Time Estimate

~1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions