-
Notifications
You must be signed in to change notification settings - Fork 38
Closed
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuecomponent: documentationDocumentation issueDocumentation issuecomponent: release engineeringRelease engineering issueRelease engineering issuepriority: lowLow PriorityLow Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: taskAn actionable item of workAn actionable item of work
Milestone
Description
Describe the Task
Enhance the GitHub Workflow documentation by adding information about how the Cycle selection can only be added after the Issue is created and how the Cycle and Issue selection can only be added after the PR is created.
Use the following for PRs from George from Slack in the "Open a pull request" section:
- Before the pull request is created, one can select the development project, but cannot select a cycle:
- After the PR is created, more options appear until the Project section:
- Click the status pull down and select "Review":
- Click on "+1 more" then click "Choose an iteration" under "Cycle" and select the current development cycle:
- Click on the gear next to "Development," type the issue number that corresponds to the work, then select the issue that is displayed:
For Issues (potentially modify the “Find the GitHub issue” section to be “Find the or Create a GitHub issue” section):
- Before the issue is created, one can select the development project, but cannot select a cycle:
- After the PR is created, more options appear until the Project section:
- Click the status pull down and select "Review":
- Click on "+1 more" then click "Choose an iteration" under "Cycle" and select the current development cycle:
Time Estimate
Estimate the amount of work required here.
<1 day
Sub-Issues
Consider breaking the task down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
None
Funding Source
Request is in for Tara to assign; Waiting to hear back.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Task Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Add any new Python packages to the METplus Components Python Requirements table.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuecomponent: documentationDocumentation issueDocumentation issuecomponent: release engineeringRelease engineering issueRelease engineering issuepriority: lowLow PriorityLow Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: taskAn actionable item of workAn actionable item of work