Describe the Problem

The Soil Moisture use case runs PCP-Combine and will work for 30 year averaging, 5, year, and 2 years, but it fails when trying to run 3 years worth of data. In conversation with George, we suspected that the bug lies in the logic that builds the accumulations in PCPCombine wrapper and is likely related to leap years

Expected Behavior

PCP-Combine should work correctly for 3 years.

Environment

Describe your runtime environment:
Derecho, Casper, GitHub Actions all fail

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
#954

Relevant Deadlines

Hopefully before the 6/11/2025 training

Funding Source

308017 STORM

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Review default alert labels
• Select component(s)
• Select priority
• Select requestor(s)

Milestone and Projects

• Select Milestone as the next bugfix version
• Select Coordinated METplus-X.Y Support project for support of the current coordinated release
• Select METplus-Wrappers-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdataio, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.

• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>

• Fix the bug and test your changes.

• Add/update log messages for easier debugging.

• Add/update unit tests.

• Add/update documentation.

• Add any new Python packages to the METplus Components Python Requirements table.

• Push local changes to GitHub.

• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>

• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Development issue
  Select: Milestone as the next bugfix version
  Select: Coordinated METplus-X.Y Support project for support of the current coordinated release

• Iterate until the reviewer(s) accept and merge your changes.

• Delete your fork or branch.

• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Development issue
  Select: Milestone as the next official version
  Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release

• Close this issue.