-
Notifications
You must be signed in to change notification settings - Fork 38
Description
The time skipping logic should be revisited in RuntimeFreq wrapper to prevent errors when a run time is skipped.
Describe the Problem
In the example where this was discovered, SeriesAnalysis was run once per init and an init time was specified to be skipped. The current logic skips finding files for each lead time specified, so it doesn't find any files, but then it errors because no files were found.
Expected Behavior
If a time is set to be skipped, it should skip gracefully without any errors.
A fix could involve calling the skip_time function earlier in execution and skipping the entire run time.
While making this fix, we should change the logging for skipping times from DEBUG to INFO so it is more clear in the logs that a time was skipped.
Environment
Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)
To Reproduce
Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
#954
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
CPO 2700044 (if over 10 hours, please contact John O before working/charging)
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Review default alert labels
- Select component(s)
- Select priority
- Select requestor(s)
Milestone and Projects
- Select Milestone as the next bugfix version
- Select Coordinated METplus-X.Y Support project for support of the current coordinated release
- Select METplus-Wrappers-X.Y.Z Development project for development toward the next official release
Define Related Issue(s)
Consider the impact to the other METplus components.
Bugfix Checklist
See the METplus Workflow for details.
-
Complete the issue definition above, including the Time Estimate and Funding Source.
-
Fork this repository or create a branch of main_<Version>.
Branch name:bugfix_<Issue Number>_main_<Version>_<Description>
-
Fix the bug and test your changes.
-
Add/update log messages for easier debugging.
-
Add/update unit tests.
-
Add/update documentation.
-
Add any new Python packages to the METplus Components Python Requirements table.
-
Push local changes to GitHub.
-
Submit a pull request to merge into main_<Version>.
Pull request:bugfix <Issue Number> main_<Version> <Description>
-
Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the next bugfix version
Select: Coordinated METplus-X.Y Support project for support of the current coordinated release -
Iterate until the reviewer(s) accept and merge your changes.
-
Delete your fork or branch.
-
Complete the steps above to fix the bug on the develop branch.
Branch name:bugfix_<Issue Number>_develop_<Description>
Pull request:bugfix <Issue Number> develop <Description>
Select: Reviewer(s) and Development issue
Select: Milestone as the next official version
Select: METplus-Wrappers-X.Y.Z Development project for development toward the next official release -
Close this issue.
Metadata
Metadata
Assignees
Labels
Type
Projects
Status