-
Notifications
You must be signed in to change notification settings - Fork 38
Closed
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuecomponent: CI/CDContinuous integration and deployment issuesContinuous integration and deployment issuespriority: blockerBlockerBlockerrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: update truthUpdate truth datasetUpdate truth dataset
Milestone
Description
Describe Expected Changes
Issue dtcenter/MET#2583 and pull request dtcenter/MET#2838 adds new columns to the end of the ECNT line type.
- Add 2 new ECNT columns: IGN_CONV_OERR and IGN_CORR_OERR
The changes should be limited to only the ECNT line type.
Need to validate the differences flagged in this GHA testing workflow run.
Define the Metadata
Title
- Add a link to the pull request that warranted this issue to the issue title using format Feature #2583 ecnt fix IGN_OERR_CORR MET#2838
Assignee
Assign this issue to the author of the pull request that warranted this issue. Optionally assign anyone else who should review the differences in the output.
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Update Truth Checklist
- Review the GitHub Actions workflow that was triggered by the PR merge
- If no differences were found, note this in a comment.
- If all of the differences are expected, note this in a comment.
Include any details of how the review was performed. - If unexpected differences are found, the following instructions can
help uncover potential explanations. If none of these apply and the
source of the differences cannot be determined, contact the
METplus wrappers lead engineer (@georgemccabe) for assistance.- Search for other open issues that have the label
type: update truth
applied by clicking on the label on this issue. Coordinate with the
author of these issues to ensure all diffs are properly reviewed. - Check if any additional GitHub Actions testing workflows have been
triggered since the workflow that corresponds to this issue was run.
Review the latest run to ensure that there are no diffs that are
unrelated to this issue. - If the incorrect differences are caused by the changes from the
issue that warranted this issue, consider reverting the PR and
re-opening the issue.
- Search for other open issues that have the label
- Iterate until one of the above conditions apply.
- Approve the update of the truth data
- Contact the METplus wrappers lead engineer (@georgemccabe) or
backup lead (@jprestop) to let them know that the truth data can
be updated.
- Contact the METplus wrappers lead engineer (@georgemccabe) or
- Update the truth data.
This should be handled by a METplus wrappers engineer.
See the (instructions to update the truth data)[https://metplus.readthedocs.io/en/develop/Contributors_Guide/continuous_integration.html#update-truth-data-update-truth-data-yml]
for more info. - Close this issue.
Metadata
Metadata
Assignees
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuecomponent: CI/CDContinuous integration and deployment issuesContinuous integration and deployment issuespriority: blockerBlockerBlockerrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: update truthUpdate truth datasetUpdate truth dataset