Skip to content

Enhance the TC-Diag wrapper to support new configuration options added in MET-12.0.0-beta2 #2432

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

Issue dtcenter/MET#2550 and pull request dtcenter/MET#2728 modifies the TC-Diag configuration file as described below. These changes were made during the MET-12.0.0-beta2 development cycle. Please enhance the TC-Diag wrapper to handle these changes.

  • The nc_rng_azi_flag is renamed as nc_cyl_grid_flag but retains the same functionality. They just liked the new name better. There is no need to support backward compatibility here.
  • The output_prefix option is removed and largely replaced by output_base_format. It is also a string but contains embedded curly braces that are used to substitute values by the the C++ code.
output_base_format = "s{storm_id}_{technique}_doper_{init_ymdh}";
  • The commented out censor_thresh, censor_val, and convert(x) options are fully removed because the user would specify them if needed using the METplus VAR<n>_OPTIONS entries.
  • The override_diags entry is a new array of strings added to each dictionary entry of the domain_info array. It should be set the same sort of way the exiting domain, n_range, etc, entries are already specified:
      domain         = "nest";
      n_range        = 150;
      n_azimuth      = 8;
      delta_range_km = 2.0;
      diag_script    = [ "MET_BASE/python/tc_diag/compute_tc_diag.py MET_BASE/python/tc_diag/config/post_resample_nest.yml MET_BASE/tc_data/v2023-04-07_gdland_table.dat" ];
      override_diags = [ "RMW", "SST" ]; 

Time Estimate

4 hours?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

Ideally do this during the METplus-6.0.0-beta3 development cycle.

Funding Source

2770043

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required
    Recommend @georgemccabe doing the work and asking @jvigh to review the resulting PR.

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions