Skip to content

Enhance the TC-Pairs wrapper to support the new diag_required and diag_min_req configuration options #2430

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

Issue dtcenter/MET#2699 and pull request dtcenter/MET#2736 adds 2 new configuration options to the array of consensus dictionaries.

  • diag_min_req is similar to the min_req entry to specify the required number of diagnostics present to be included in the output.
  • diag_required is similar to the required entry to specify the models that must contain diagnostics for them to be calculated.
    These were added during the MET-12.0.0-beta2 development cycle. Please enhance the TC-Pairs wrapper to add support for these 2 new configuration options.

Time Estimate

4 hours?

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

Ideally do this during the METplus-6.0.0-beta3 development cycle.

Funding Source

2770043

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required
    Recommend @georgemccabe doing the work and asking @jvigh to review the resulting PR.

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions