-
Notifications
You must be signed in to change notification settings - Fork 38
Closed
Closed
Copy link
Labels
component: code cleanupCode cleanup and maintenance issueCode cleanup and maintenance issuepriority: highHigh PriorityHigh Priorityrequestor: NOAA/EMCNOAA Environmental Modeling CenterNOAA Environmental Modeling Centertype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Milestone
Description
The logic that traverses a directory to find files that fall within a time window (FILE_WINDOW) does not follow symbolic links, so directories that contain links will not be traversed. This came up in discussion #2415
Describe the Enhancement
The call to os.walk in the _get_closest_files function in metplus/wrappers/command_builder.py should include the argument followlinks=True
Time Estimate
Estimate the amount of work required here.
Issues should represent approximately 1 to 3 days of work.
Sub-Issues
Consider breaking the enhancement down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED CYCLE ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Add any new Python packages to the METplus Components Python Requirements table.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Development issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
component: code cleanupCode cleanup and maintenance issueCode cleanup and maintenance issuepriority: highHigh PriorityHigh Priorityrequestor: NOAA/EMCNOAA Environmental Modeling CenterNOAA Environmental Modeling Centertype: enhancementImprove something that it is currently doingImprove something that it is currently doing