In 4.0.0 and earlier, the PCPCombine wrapper logic for running in -subtract mode when the subtracted forecast lead/accum is 0 is to run pcp_combine with -add mode with a single input file. However, we have encountered data that contains 0 hr lead/accum that need to be used. A fix was added in a 4.1.0 beta release to only execute this logic if the 2nd accum is 0 and the input datatype is set to GRIB. However, it is cryptic and misleading to require setting [FCST/OBS]_PCP_COMBINE_INPUT_DATATYPE = GRIB to force the previous behavior of using -add in this case.

Describe the Enhancement

Add a new config option called [FCST/OBS]_PCP_COMBINE_USE_ZERO_ACCUM that defaults to False and can be set to force using the zero hour accum in subtract mode.

Time Estimate

<1 day

Relevant Deadlines

4.1.0

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Enhancement Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of develop.
  Branch name: feature_<Issue Number>_<Description>
• Complete the development and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Push local changes to GitHub.
• Submit a pull request to merge into develop.
  Pull request: feature <Issue Number> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Close this issue.