-
Notifications
You must be signed in to change notification settings - Fork 38
Open
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuealert: NEED MORE DEFINITIONNot yet actionable, additional definition requiredNot yet actionable, additional definition requiredcomponent: build processBuild process issueBuild process issuecomponent: documentationDocumentation issueDocumentation issuepriority: highHigh PriorityHigh Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Milestone
Description
Currently the build_components/build_MET.sh does not work as intended.
This issue needs dtcenter/MET#1920 to be completed before it can be completed.
Describe the Enhancement
Get the script to work.
Here are some notes of some of the changes that are needed:
- Cannot run ./build_components/build_MET.sh because commands assume running from build_components directory
- add cd "$( dirname "${BASH_SOURCE[0]}" )" to beginning to change into directory containing script
- Externals_stable.cfg : branch cannot be a tag
- change all to main_vX.Y, i.e. v10.0.0 to main_v10.0
- Add git ignores for MET, METdatadb, METviewer and other files downloaded into build_components i.e. tar_files, gfdl tracker, etc
- QUESTION: why include wget and curl commands in build_MET.sh script? Why not just use curl?
- GFDL tracker cannot be installed with GNU with the version downloaded in script, but example env_var.bash uses gnu. There is a process to installing with GNU that is listed in ci/docker/docker_env/Dockerfile.gfdl-tracker
- This command fails because this file does not exist: tar -xzvf compile_MET_all.sh.tgz
Time Estimate
1-3 days
Relevant Deadlines
List relevant project deadlines here or state NONE.
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components. Changes in other repositories may be needed to get this to work.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.
Metadata
Metadata
Assignees
Labels
alert: NEED ACCOUNT KEYNeed to assign an account key to this issueNeed to assign an account key to this issuealert: NEED MORE DEFINITIONNot yet actionable, additional definition requiredNot yet actionable, additional definition requiredcomponent: build processBuild process issueBuild process issuecomponent: documentationDocumentation issueDocumentation issuepriority: highHigh PriorityHigh Priorityrequestor: METplus TeamMETplus Development TeamMETplus Development Teamtype: enhancementImprove something that it is currently doingImprove something that it is currently doing
Type
Projects
Status
🩺 Needs Triage