Skip to content

Enhance the GridStat and PointStat wrappers to handle the addition of SEEPS. #1953

@JohnHalleyGotway

Description

@JohnHalleyGotway

Describe the Enhancement

PR dtcenter/MET#2344 for issue dtcenter/MET#1943 adds support to the MET Grid-Stat tool for computing SEEPS, and tweaks it for Point-Stat. This required 3 changes to the Grid-Stat configuration file and 1 change to the Point-Stat configuration file. This issue is to update the METplus GridStat and PointStat wrappers accordingly.

The specific diffs can be seen here for Grid-Stat and here for Point-Stat, but are described below:

  1. Add Grid-Stat entry for output_flag.seeps which can be set to NONE, STAT, or BOTH with default = NONE.
  2. Add Grid-Stat entry for nc_pairs_flag.seeps which can be set to TRUE or FALSE with default = FALSE.
  3. Add Grid-Stat top-level seeps_p1_thresh option to define a threshold with default = NA (where NA is a threshold type always evaluating to true).
  4. Add Point-Stat top-level seeps_p1_thresh option as described above.

Time Estimate

4 hours

Sub-Issues

Consider breaking the enhancement down into sub-issues.
None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required: @georgemccabe
  • Select scientist(s) or no scientist required: none needed

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions