Skip to content

TCPairs and TCStat - add support for new config options and command line arguments #1898

@georgemccabe

Description

@georgemccabe

dtcenter/MET#2315 added new options that will need to be supported.

Describe the Enhancement

Add support in TCPairs wrapper for setting the following in the wrapped MET config file:

  • diag_name - list of strings
  • diag_convert_map - list of dictionaries that each contain source (string), key (list of strings), and convert (string with no quotes) - This can be handled by using the add_met_config_dict_list function found in util/met_config

Add support for setting the optional -diag {source path} command line argument in the TCPairs wrapper

Add support in TCStat wrapper for setting the following in the wrapped MET config file:

  • diag_thresh_name (list of strings?)
  • diag_thresh_val (list of thresholds? < or gt notation?)
  • init_diag_thresh_name (list of strings?)
  • init_diag_thresh_val (list of thresholds? < or gt notation?)

Add support for setting -diag_thresh and -init_diag_thresh (optional?) command line arguments in the TCStat wrapper (if needed, these may be set in the job args only)

Time Estimate

~2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

NOAA WPO - JTTI TCDiag Project (2770043)

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Labels

alert: NEED MORE DEFINITIONNot yet actionable, additional definition requiredrequired: FOR DEVELOPMENT RELEASERequired to be completed in the development release for the assigned projecttype: enhancementImprove something that it is currently doing

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions