-
Notifications
You must be signed in to change notification settings - Fork 38
Description
Currently the StatAnalysis wrapper only sets certain string substitution templates based on the LOOP_BY setting. If LOOP_BY = INIT, then init_beg and init_end are set, while valid_beg and valid_end are not. If LOOP_BY = VALID, then valid_beg and valid_end are set, while init_beg and init_end are not. @CPKalb has been working on a use case for UAE that needs to loop by init time and it would be less confusing if the output filenames could be named referring to valid time.
Describe the Enhancement
Enhance the StatAnalysis wrapper to compute the begin and end times of the opposite of the LOOP_BY value (e.g. init if valid and valid if init). The minimum and maximum forecast leads specified with FCST_LEAD_LIST and OBS_LEAD_LIST can be used to calculate these values.
Time Estimate
~3 days
Sub-Issues
Consider breaking the enhancement down into sub-issues.
- Add a checkbox for each sub-issue here.
Relevant Deadlines
5.0.0
Funding Source
Define the source of funding and account keys here or state NONE.
Define the Metadata
Assignee
- Select engineer(s) or no engineer required
- Select scientist(s) or no scientist required - @CPKalb as needed for testing
Labels
- Select component(s)
- Select priority
- Select requestor(s)
Projects and Milestone
- Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
- Select Milestone as the next official version or Future Versions
Define Related Issue(s)
Consider the impact to the other METplus components.
Enhancement Checklist
See the METplus Workflow for details.
- Complete the issue definition above, including the Time Estimate and Funding Source.
- Fork this repository or create a branch of develop.
Branch name:feature_<Issue Number>_<Description>
- Complete the development and test your changes.
- Add/update log messages for easier debugging.
- Add/update unit tests.
- Add/update documentation.
- Add any new Python packages to the METplus Components Python Requirements table.
- Push local changes to GitHub.
- Submit a pull request to merge into develop.
Pull request:feature <Issue Number> <Description>
- Define the pull request metadata, as permissions allow.
Select: Reviewer(s) and Linked issues
Select: Repository level development cycle Project for the next official release
Select: Milestone as the next official version - Iterate until the reviewer(s) accept and merge your changes.
- Delete your fork or branch.
- Close this issue.