Skip to content

Enhance logic to consistently create directories #1657

@georgemccabe

Description

@georgemccabe

This came up in the METplus NOAA Telecon on 6/13/2022

Creating new directories is handled inconsistently in the wrapper logic. Sometimes the util.mkdir_p function is used, which uses Path to create a directory and ensures that it will still be created even if the directory exists or the parent directory does not exist. Other places uses os.makedirs which will raise an exception if the directory already exists. The logic typically checks if the directory exists and only creates it if it does not. However, the user attempted to run 8 instances at METplus at once. Likely what happened is the check for the directory existence was executed at the same time, then all instances attempted to create this directory which now exists from 1 of them successfully creating it.

Describe the Enhancement

Update the logic to always use the util.mkdir_p function instead of os.makedirs.

Time Estimate

1-2 days

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions