Skip to content

Bugfix: Add missing brackets around list variable values for StatAnalysis wrapper #1641

@CPKalb

Description

@CPKalb

This came up in discussion #1639

Describe the Problem

When trying to run multiple lead times using the StatAnalysis config file, the lead list is missing brackets. This causes a syntax error as listed below
ERROR :
ERROR : yyerror() -> syntax error in file "/lus/work/wrf/kalb/met/tmp/met_config_118109_0"
ERROR :
ERROR : line = 15
ERROR :
ERROR : column = 9
ERROR :
ERROR : text = ","
ERROR :
ERROR :
ERROR : fcst_lead = "010000", "020000", "030000", "040000", "050000", "060000", "070000", "080000", "090000", "100000", "110000", "120000", "130000", "140000", "150000", "160000", "170000", "180000", "190000", "200000", "210000", "220000", "230000", "240000";
ERROR : ^__________________________________________________________________________________________________________________________________________________________________________________________________________________________________________
ERROR :

Expected Behavior

Brackets need to be added to the fcst_lead_list in the stat analysis wrapper so that this works as expected.

Environment

Describe your runtime environment:
*1. HPC machine Atmosphere
*2. unknown
*3. METplus 4.1

To Reproduce

Describe the steps to reproduce the behavior:
*1. Run the stat analysis wrapper with more than 1 item listed in FCST_LEAD_LIST
*2. Make sure to specify STAT_ANALYSIS_CONFIG_FILE = /path/to/file/filename
*3. Run stat analysis

A sample .conf file that causes this error is attached:
StatAnalysis_fcstCOSMO_obsAWS_Sfc.conf.txt

Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

7740181

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Relationships

None yet

Development

No branches or pull requests

Issue actions