This came up in Discussion #1619

Describe the Problem

The value set for -qc or -adp are not actually added to the command.

        if self.c_dict['QC_FLAGS']:
            self.args.append("-qc")

        if self.c_dict['ADP']:
            self.args.append("-adp")

Expected Behavior

The value set for POINT2GRID_QC_FLAGS and/or POINT2GRID_ADP should be added to the command.

        if self.c_dict['QC_FLAGS']:
            self.args.append(f"-qc {self.c_dict['QC_FLAGS']}")

        if self.c_dict['ADP']:
            self.args.append(f"-adp {self.c_dict['ADP']}")

Also review the rest of the command line arguments to ensure that they are set properly.

Environment

Any

To Reproduce

Run Point2Grid wrapper with POINT2GRID_QC_FLAGS and/or POINT2GRID_ADP set to reproduce the error.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

• Select engineer(s) or no engineer required
• Select scientist(s) or no scientist required

Labels

• Select component(s)
• Select priority
• Select requestor(s)

Projects and Milestone

• Select Organization level Project for support of the current coordinated release
• Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
• Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

• METplus, MET, METdatadb, METviewer, METexpress, METcalcpy, METplotpy

Bugfix Checklist

See the METplus Workflow for details.

• Complete the issue definition above, including the Time Estimate and Funding Source.
• Fork this repository or create a branch of main_<Version>.
  Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
• Fix the bug and test your changes.
• Add/update log messages for easier debugging.
• Add/update unit tests.
• Add/update documentation.
• Add any new Python packages to the METplus Components Python Requirements table.
• Push local changes to GitHub.
• Submit a pull request to merge into main_<Version>.
  Pull request: bugfix <Issue Number> main_<Version> <Description>
• Define the pull request metadata, as permissions allow.
  Select: Reviewer(s) and Linked issues
  Select: Organization level software support Project for the current coordinated release
  Select: Milestone as the next bugfix version
• Iterate until the reviewer(s) accept and merge your changes.
• Delete your fork or branch.
• Complete the steps above to fix the bug on the develop branch.
  Branch name: bugfix_<Issue Number>_develop_<Description>
  Pull request: bugfix <Issue Number> develop <Description>
  Select: Reviewer(s) and Linked issues
  Select: Repository level development cycle Project for the next official release
  Select: Milestone as the next official version
• Close this issue.