Skip to content

Allow FCST_IS_PROB variable setting specific to tool (FCST_<tool_name>_IS_PROB) #1586

@j-opatz

Description

@j-opatz

Describe the Enhancement

Currently, setting FCST_IS_PROB to True in one tool will cause any additional tool being called in a use case to also have FCST_IS_PROB = True, no matter where in the process list that variable is set. This is problematic, for instance in use cases where uncalibrated probabilistic data is being created from GenEnsProd output, but tools prior to GenEnsProd are reading in continuous data fields.

The current system has a workaround using user-defined instances for the probabilistic tool. For example, if 3 tools are called in the following order:

PROCESS_LIST = SeriesAnalysis, GenEnsProd, GridStat

and GridStat needs FCST_IS_PROB = True while the other two tools don't, they can use:

PROCESS_LIST = SeriesAnalysis, GenEnsProd, GridStat(my_instance)

and

[my_instance]
FCST_IS_PROB = True

will produce the desired output. The successful resolution of this issue will mean that the workaround is no longer needed and users can use

FCST_GRID_STAT_IS_PROB = True

instead.

Time Estimate

Engineer to provide better estimate

Sub-Issues

Consider breaking the enhancement down into sub-issues.

  • Add a checkbox for each sub-issue here.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Repository and/or Organization level Project(s) or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next official version or Future Versions

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of develop.
    Branch name: feature_<Issue Number>_<Description>
  • Complete the development and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Add any new Python packages to the METplus Components Python Requirements table.
  • Push local changes to GitHub.
  • Submit a pull request to merge into develop.
    Pull request: feature <Issue Number> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Close this issue.

Metadata

Metadata

Type

No type

Projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions