Skip to content

Fix logic to use fcst dictionary if ens dictionary is not set in EnsembleStat wrapper #1421

@georgemccabe

Description

@georgemccabe

If the ENS_VAR_ variables are not set in an EnsembleStat use case, the previous logic was to use the fcst dictionary field info. This logic appears to be broken.

Describe the Problem

A use case was recently discovered to be missing from the automated tests. It turns out this use case has broken due to this issue. The use case should be added back to the automates tests once this is fixed.

Expected Behavior

The model_applications/precipitation/EnsembleStat_fcstWOFS_obsWOFS.conf use case should not fail and should set the ens dictionary to use the same fields as the fcst dictionary since it is not set in the METplus config file.

Environment

MET 10.0.0 or higher? MET 10.1.0-betaX may be needed but unlikely

To Reproduce

Describe the steps to reproduce the behavior:
Run the use case and confirm that it fails

Relevant Deadlines

4.1.0

Funding Source

NONE

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Select component(s)
  • Select priority
  • Select requestor(s)

Projects and Milestone

  • Select Organization level Project for support of the current coordinated release
  • Select Repository level Project for development toward the next official release or add alert: NEED PROJECT ASSIGNMENT label
  • Select Milestone as the next bugfix version

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Linked issues
    Select: Organization level software support Project for the current coordinated release
    Select: Milestone as the next bugfix version
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Linked issues
    Select: Repository level development cycle Project for the next official release
    Select: Milestone as the next official version
  • Close this issue.

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions