Handle variable length lines with more than 125 columns after the header, especially for HiRA (issue #78) #79
Conversation
There was a problem hiding this comment.
I was able to load the MET output file with long data. The problem rows were sipped.
I assume that for each skipped row METdatadb displayes a message similar to ERROR:root:*** Variable length record RHIST deleted as too long ***
It would be nice if the messages were more informative and display, if possible of course, a file name, the line number and the reason why the row were ignored so the users have reasonable expectations when they use DB data. For example:
WARNING: the line #5419 in file ensemble_stat_20100101_120000V.stat was sipped because n_rank = 151 and bigger then limit <some_limit>
|
I'm going to remove myself as a reviewer of this PR since I think @TatianaBurek is a better, and sufficient, reviewer. |
|
Improved error message for long lines that are skipped. |
Pull Request Testing
Auto test ran successfully, and both John's data from related MET PR [https://github.com/dtcenter/MET/issues/1583] and full METviewer test data ran successfully.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes