Feature 13 eckit atlas #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
I ran the following to create a Docker image for METbaseimge:
I ran the following to create a local MET image after modifying the Dockerfile to specify my branch:
I ran the following and checked to see that there were no errors and the executables were built and ran a simple Python embedding example which ran successfully
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Please review the testing I did to ensure it is sufficient.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [I think so... let me know if you think of something I've missed]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Please complete this pull request review by [11/10/2023].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s)
Select: Organization level software support Project or Repository level development cycle Project
Select: Milestone as the version that will include these changes