Skip to content

Conversation

jprestop
Copy link
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    I ran the following to create a Docker image for METbaseimge:
docker build -t dtcenter/met-base:feature_2611_oneapi --build-arg MET_COMPILE_SCRIPT_BRANCH=feature_2611_oneapi -f Dockerfile .

I ran the following to create a local MET image after modifying the Dockerfile to specify my branch:

export TAG_NAME=feature_2611_oneapi
export BRANCH_NAME=feature_2611_oneapi
export MET_GIT_NAME=feature_2611_oneapi
docker build -t dtcenter/met:${TAG_NAME} --build-arg SOURCE_BRANCH=${BRANCH_NAME} internal/scripts/docker

I ran the following and checked to see that there were no errors and the executables were built and ran a simple Python embedding example which ran successfully

docker run -it --rm dtcenter/met:feature_2611_oneapi /bin/bash
cd MET-feature_2611_oneapi/
plot_data_plane PYTHON_NUMPY plot.ps 'name="scripts/python/examples/read_ascii_numpy.py data/python/fcst.txt fcst";'
echo $?
0
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Please review the testing I did to ensure it is sufficient.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [I think so... let me know if you think of something I've missed]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Please complete this pull request review by [11/10/2023].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s)
    Select: Organization level software support Project or Repository level development cycle Project
    Select: Milestone as the version that will include these changes
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METbaseimage 3.1 milestone Nov 10, 2023
@jprestop jprestop linked an issue Nov 10, 2023 that may be closed by this pull request
21 tasks
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all of your work on this @jprestop and describing the testing you've already done.

I approve of these changes to add the compilation of Atlas and ecKit to the METbaseimage.

Please feel free to merge this PR. We should discuss what order of operations are needed prior to creating the METbaseimage v3.1 release.

I suspect that the MET feature_2611_oneapi branch needs to be merged into develop prior to cutting the METbaseimage v3.1 release.

@jprestop jprestop merged commit cb60a0d into main Nov 14, 2023
@JohnHalleyGotway JohnHalleyGotway deleted the feature_13_eckit_atlas branch June 26, 2025 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Enhance METbaseimage to compile the ecKit and Atlas libraries
2 participants