Feature #3198 develop scan_for_CVEs #3199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
…er_image.sh script.
This was referenced Jul 14, 2025
jprestop
approved these changes
Jul 15, 2025
There was a problem hiding this comment.
These changes are great, @JohnHalleyGotway! Thank you for all of your time and effort. I reviewed the GHA updates, noting the adding warning message and inspected the CVE scan output log file, CVE_Scan_dtcenter_met_12.0.2.log, which was as expected. I approve this request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Used workflow dispatch in this release-docker-images.yml run for this
feature_3198_develop_scan_for_CVEsbranch to build thedtcenter/met:12.0.2image and confirmed that the steps now include the CVE scanning output, like this:I downloaded the log artifact and confirmed it now contains the CVE scan output.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review GHA updates and inspect the CVE scan output.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
I made no updates to the MET documentation.
Do these changes include sufficient testing updates? [No]
None needed.
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fri July 18, 2025].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release