Updated note in UGRID documentation #3188
Conversation
There was a problem hiding this comment.
Thanks for updating this @j-opatz! I suggest being a little more specific. Here's my attempt:
For Point-Stat, evaluation occurs by interpolating directly between the UGRID and observation points and does not require regridding.
Also, I'm not sure if you want to be specific enough to note this, but the capability is currently limited to nearest-neighbor interpolation, so you could optionally mention that.
|
Great suggestion, @willmayfield. I've updated the language to match your suggestion. I think the documentation does a sufficient job at noting that NEAREST is the only supported method at the moment. I've gone ahead and re-requested your review; if you'll approve now, I can get this PR into the develop branch before the weekend. |
There was a problem hiding this comment.
@j-opatz I'm proposing a tweak to the wording to clarify that it's the UGRID data that's interpolation to point locations. I think "between" is less clear than it could be. It leaves open the possibility of interpolating point obs to UGRID locations.
Co-authored-by: John Halley Gotway <johnhg@ucar.edu>
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [ No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Added small detail that Point-Stat does not need regridding for UGRID processing.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the docs update, see if it reads in a sensible way.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [7/2].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release