Skip to content

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Jun 10, 2025

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Replaced include using sed in conda build and confirmed that it built successfully after the change.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 6/13/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe georgemccabe added this to the MET-12.2.0 milestone Jun 10, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.2 Development Jun 10, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.2 Development Jun 10, 2025
@georgemccabe georgemccabe marked this pull request as ready for review June 10, 2025 15:19
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of this PR.

Thanks @georgemccabe for finding/fixing this problem. FYI, I double-checked that this change compiles on seneca with both GNU and Intel:

  1. Tested GNU in seneca /d1/projects/MET/MET_pull_requests/met-12.1.0/coordinated/MET-bugfix_3175_main_v12.1_include.
  2. Tested Intel in seneca /d1/projects/MET/MET_pull_requests/met-12.2.0/rc1/MET-bugfix_3175_develop_include.

Both compile fine!

@georgemccabe georgemccabe merged commit 749bcc9 into develop Jun 10, 2025
40 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.2 Development Jun 10, 2025
@georgemccabe georgemccabe deleted the bugfix_3175_develop_include branch June 10, 2025 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Bugfix: Fix compilation on non-GCC compilers by replacing #include <bits/stdc++.h>
2 participants