Bugfix 3164 slice range sonarqube #3173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsoh-u
added a commit
that referenced
this pull request
Jun 24, 2025
* #3164 Removed duplicated code * #3164 Added more API to handle the slice by value * Merged fixes for the SonarQube * #3164 Fix the SonarQUbe findings * #3164 Corrected const declarations * #3164 Corrected const declarations * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings: const --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> * #3164 Suuport @lower-@upper notation * #3164 Renamed error_code_bad_offset to error_code_out_of_index * Bugfix 3164 slice range sonarqube (#3173) * #3164 Fix the SonarQUbe findings * #3164 Corrected const declarations * #3164 Corrected const declarations * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings * #3164 Fixes for SonarQube findings: const * Renamed error_code_bad_offset to error_code_out_of_index --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> * #3164 Initialize cur_time_index and cur_z_index * #3164 Changed offset 0 to time string. Changed two @ notation level * #3164 Corrected typo * #3164 SonarQube code smell * #3164 SonarQube code smell * #3164 CHnaged warning to error for bad offset for Z --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu>
hsoh-u
pushed a commit
that referenced
this pull request
Jul 15, 2025
hsoh-u
added a commit
that referenced
this pull request
Aug 4, 2025
* #3172 Added get_grib_var_name * #3172 Added grib_code_map * #3172 Fixed SonarQube findings * #3172 Use the grib variable name instead of grib_code from the configuration * #3172 Added grib_unit_map * 172 Added var_units and read it * 172 Added var_units_set and process_var_units * 172 Calls process_var_units if use_var_id is true * #3172 Added parse_conf_key_values_map * #3172 Use an integer key for grib code * #3172 Added point_stat_QTY_INC_EXC_MADIS * Defined grib_var_map * #3172 Cleanup for SonarQube findings * #3172 Cleanup for SonarQube findings * #3172 FIx SonarQube findings * #3172 Added var_descs * #3172 Added grib_var_map for madis2nc * #3172 Fix SonarQube findings * #3172 CHeck var_names and var_units at process_var_units * #3173 Modified the comment for grib_var_map * #3172 Rollback (removed point_stat_QTY_INC_EXC_MADIS) --------- Co-authored-by: Howard Soh <hsoh@seneca.rap.ucar.edu> Co-authored-by: MET Tools Test Account <met_test@seneca.rap.ucar.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No]
Do these changes include sufficient testing updates? [Yes or No]
Will this PR result in changes to the MET test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [Yes or No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release