Skip to content

Conversation

hsoh-u
Copy link
Collaborator

@hsoh-u hsoh-u commented May 19, 2025

Expected Differences

None except warning during build
The first argument with PyConfig_SetArgv was not passed to the python scripts. So the first argument was added again at the C code.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Build and existing unit tests

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Build and check no warning with Python APIs.

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

There is a diff, but I doubt it's from this PR.

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:
    Reduced to 15,615 (from 15,715).

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET-12.1.0 milestone May 19, 2025
@hsoh-u hsoh-u requested a review from JohnHalleyGotway May 19, 2025 19:15
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development May 19, 2025
@JohnHalleyGotway JohnHalleyGotway moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development May 19, 2025
@JohnHalleyGotway JohnHalleyGotway changed the title Feature 3106 python deprecated api Feature #3106 python deprecated api May 19, 2025
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

To test, I...

  1. Confirmed the reduction of SonarQube code smells. Great job reducing those!
  2. Confirmed that all unit tests run and no diffs are flagged.
  3. Confirmed that compiling in seneca /d1/projects/MET/MET_pull_requests/met-12.1.0/rc1/MET-feature_3106_python_deprecated_API produces no compilation warning messages for GNU (make_gnu.log).
  4. Reviewed the actual code changes.

@hsoh-u hsoh-u merged commit 2e949d5 into develop May 19, 2025
63 of 67 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: 🏁 Done
Development

Successfully merging this pull request may close these issues.

Resolve Python deprecation warnings introduced during the switch to Python 3.12
2 participants