Feature 3119 installation files #3138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstallation_files
22 tasks
JohnHalleyGotway
approved these changes
Apr 28, 2025
There was a problem hiding this comment.
I approve of these changes. I scanned the changes major issues jumped out. Of course, the v12.1.0-rc1.tar.gz tarfile does not actually exist yet but it will be created for the MET-12.1.0-rc1 release on/around May 21st.
I note the following details:
- The testing workflow flagged no diffs.
- The SonarQube workflow flagged no issues.
- The Python version is increased by 3.10 to 3.12.
- Increase from BUFRLIB version 11.5.0 to 11.6.0 on Acorn.
- On Acorn, link to WCOSS libraries on
devrather thanprod. - New Python 3.12 miniconda environments on Casper, Hera, Jet, and Orion.
- Increase from Intel OneAPI version 2022.2.1 to 2024.1.0 on Jet and Orion.
- Casper, Hera, Jet:
|
Thank you for your review and for detailing those changes, @JohnHalleyGotway. I wish I had thought to do that initially in this PR. I'll try to remember that for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
The files that have been updated have been tested in the installations on the various machines (except for a minor change for the upcoming rc1 installation on WCOSS2, which will be tested after the rc1 release).
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the files for any obvious errors and ensure all tests pass. I plan to leave the issue open for further work after this is merged in.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [20250502].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release