Bugfix #3107 multiple grib2 entry #3129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 15, 2025 16:46
23 tasks
JohnHalleyGotway
approved these changes
Apr 16, 2025
There was a problem hiding this comment.
I approve of these changes.
I see that the changes are limited to table_lookup.h and table_lookup.cc and I see that you included some SonarQube code smells fixes. Thanks!
I tested this in seneca:/d1/projects/MET/MET_pull_requests/met-12.1.0/rc1/MET-bugfix_3107_multiple_grib2_entry with the following command for the source #3107 issue:
plot_data_plane /d1/projects/METplus/discussions/2931/demo/2t-heightAboveGround-0002.grib2 ./out.ps 'name="TMP"; level="Z002"; GRIB2_cntr=7;GRIB2_ltab=1;GRIB2_mtab=1;' -v 3
And I note that when testing with the NB version /d1/projects/MET/MET_regression/develop/NB20250416/MET-develop/bin/plot_data_plane, the following log message appear:
DEBUG 3: Multiple GRIB2 table entries match lookup criteria (parm_name = TMP, grib2_mtab = 1, grib2_cntr = 7, grib2_ltab = 1):
DEBUG 3: parm_name: TMP, index_a = 0, grib2_mtab = 1, grib2_cntr = 0, grib2_ltab = 0, index_b = 0, index_c = 0
DEBUG 3: parm_name: TMP, index_a = 0, grib2_mtab = 1, grib2_cntr = 7, grib2_ltab = 1, index_b = 0, index_c = 0
DEBUG 3: Using the first match found: parm_name: TMP, index_a = 0, grib2_mtab = 1, grib2_cntr = 0, grib2_ltab = 0, index_b = 0, index_c = 0
But those no longer appear with the changes in this PR.
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Only difference is having log messages or not.
./plot_data_plane /d1/projects/METplus/discussions/2931/demo/2t-heightAboveGround-0002.grib2 grib2_entry.ps 'name="TMP"; level="Z002"; GRIB2_cntr=7;GRIB2_ltab=1;GRIB2_mtab=1;' -v 3
cp -p data/table_files/grib2_all.txt data/table_files/grib2_all_dup.txt
And ran the same command above
Test other cases if exist.
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [Yes or No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release