Skip to content

Feature #2794 and #2818 WRF subgrid #3122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 4, 2025
Merged

Feature #2794 and #2818 WRF subgrid #3122

merged 21 commits into from
Apr 4, 2025

Conversation

georgemccabe
Copy link
Collaborator

@georgemccabe georgemccabe commented Apr 3, 2025 •
edited
Loading

Additional changes included in this PR relating to unit testing is included in PR #3121

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

Just new env var MET_USE_WRF_SUBGRID to control reading subgrid from WRF files

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Added new unit tests.
Updated existing METplus use case to read WRF Fire data directly instead of using Python Embedding and confirmed that it worked as expected, producing the same statistics.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Review code changes

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

Added info about new env var

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the MET test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by 4/8/2025.

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@georgemccabe
per #2794, add support for reading WRF subgrid natively
1c9ece9
@georgemccabe
resolve SQ
fc70289
@georgemccabe
Per #2818, add support for vertical levels found in WRF files: bio_em…
070677e 
…issions_dimension_stag, klevs_for_dvel, soil_layers_stag, seed_dim_stag. Clean up
@georgemccabe
Merge branch 'develop' into feature_2794_wrf_subgrid
e210fab
@georgemccabe
initial version of scripts to help update MET unit test data on web s…
fe224ce 
…erver to link with automation
@georgemccabe
Merge branch 'feature_2794_wrf_subgrid' of github.com:dtcenter/MET in…
18da7d7 
…to feature_2794_wrf_subgrid
@georgemccabe
fix she-bang and clean up script
277a0f9
@georgemccabe
update contrib guide info about updating unit test data
fd8787a
@georgemccabe
resolve shell check warnings
e90239d
@georgemccabe
get real path to create symbolic links so the files will be visible o…
7da1f0b 
…n the web
@georgemccabe
ignore files that are generated by building docs and CLion
3e5386f
@georgemccabe
add info about how to run unit tests
23ab85c
@georgemccabe
add unit test for reading WRF subgrid field
957d307
@georgemccabe
per #2794, error if subgrid env var is set for projections that haven…
17c11e1 
…'t been tested
@georgemccabe
per #2794, add documentation about subgrid env var
d8ffbd5
@georgemccabe
per #2794, add another test to ensure a field from the WRF Fire file …
168cfb1 
…that is not on the subgrid can be read properly
@georgemccabe georgemccabe added this to the MET-12.1.0 milestone Apr 3, 2025
@github-project-automation github-project-automation bot moved this to 🩺 Needs Triage in METplus-6.1 Development Apr 3, 2025
@georgemccabe georgemccabe moved this from 🩺 Needs Triage to 🔎 In review in METplus-6.1 Development Apr 3, 2025
@georgemccabe georgemccabe linked an issue Apr 3, 2025 that may be closed by this pull request
Enhance MET library code to support reading WRF subgrid files #2794
Closed
22 tasks
JohnHalleyGotway
JohnHalleyGotway requested changes Apr 3, 2025
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I read looked through the proposed code changes and have only very minor feedback.

I see that this PR reduces the overall number of code smells from 17,379 in develop to
17,371 in this feature branch, which is good.

I see that the only differences are the addition of 2 new PostScript files for the 2 new plot_data_plane unit tests. I inspected the plots and was at first confused, but now understand, that the regular grid and subgrid cover the same lat/lon extent, but the subgrid data has higher resolution. The plots look reasonable to me.

For traceability and clarity, I'd recommend the following:

  1. Complete your work for the #3121 pull request.
  2. Merge #3121 into develop.
  3. Merge develop into this feature_2794_wrf_subgrid feature branch.
  4. Re-request my review of this PR.

That should prevent the #3121 changes from being included in this PR and should prevent any merge conflicts from popping up.

JohnHalleyGotway
JohnHalleyGotway approved these changes Apr 4, 2025
View reviewed changes
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes.

Looks great George! Thanks for further reducing the SonarQube code smells down to 17,352 and for getting rid of the contributor's guide false alarm code changes.

I re-confirmed that the only diffs are the addition of 2 new expected plot_data_plane output files.

@georgemccabe georgemccabe merged commit 37f927f into develop Apr 4, 2025
39 of 40 checks passed
@github-project-automation github-project-automation bot moved this from 🔎 In review to 🏁 Done in METplus-6.1 Development Apr 4, 2025
@georgemccabe georgemccabe deleted the feature_2794_wrf_subgrid branch April 4, 2025 15:54
@github-actions github-actions bot mentioned this pull request Apr 4, 2025
Merged
georgemccabe pushed a commit that referenced this pull request Apr 4, 2025
@github-actions
Update develop-ref after #3122 (#3123)
64f36c8
@JohnHalleyGotway JohnHalleyGotway linked an issue May 21, 2025 that may be closed by this pull request
Enhance MET library code to support additional vertical level types in WRF files #2818
Closed
21 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Feature #2794 WRF subgrid Feature #2794 and #2818 WRF subgrid May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnHalleyGotway JohnHalleyGotway JohnHalleyGotway approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
METplus-6.1 Development
Status: 🏁 Done
Milestone
MET-12.1.0
Development

Successfully merging this pull request may close these issues.

Enhance MET library code to support additional vertical level types in WRF files Enhance MET library code to support reading WRF subgrid files
2 participants
@georgemccabe @JohnHalleyGotway